PMM-15180 Replace local custom SVG icons with peak-ui and MUI components - #5731
Open
pmcf-percona wants to merge 4 commits into
Open
PMM-15180 Replace local custom SVG icons with peak-ui and MUI components#5731pmcf-percona wants to merge 4 commits into
pmcf-percona wants to merge 4 commits into
Conversation
WalkthroughThe PMM UI dependency changes from ChangesPeak UI migration
Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
pmcf-percona
changed the title
pmcf-percona
marked this pull request as ready for review
August 4, 2026 15:07
pmcf-percona
requested review from
fabio-silva and
mattiasimonato
and removed request for
a team
August 4, 2026 15:07
Replace PMM's bundled SVG icons with design-system and Material components and adopt the @percona/percona-ui -> @percona/peak-ui rename (@percona/peak-ui@1.0.25). - 7 brand icons + 14 custom glyphs -> @percona/peak-ui components - 24 standard glyphs -> @mui/icons-material - RTA empty state -> RealTimeDatabaseOffIllustration - remove 3 unreferenced icons + the dead `node` map alias - src/icons/ trimmed to the status icons and PMM logos, kept by design Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GvaaWAnYeGgjBFDcrFv9Jx
pmcf-percona
force-pushed
the
PMM-15180-replace-local-icons
branch
from
August 4, 2026 15:25
3904830 to
ee4420a
Compare
Signed-off-by: Claude <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket number: PMM-15180
Feature build: Percona-Lab/pmm-submodules#4509
Summary
PMM kept its own copies of ~50 brand and UI icons as local SVGs in
src/icons/, wired through a localIconcomponent andDYNAMIC_ICON_IMPORT_MAP. Most duplicated icons the design system or Material already provide. This PR sources them properly instead.The design system was renamed from
@percona/percona-uito@percona/peak-ui, so this also adopts@percona/peak-ui@1.0.25(the first release carrying the custom Peak Design icon suite) and repoints every existing import.Also in this PR:
@percona/peak-uicomponents (PerconaIcon,HaproxyIcon,ProxyIcon,PerconaMyIcon/MoIcon/PoIcon/VaIcon), and the RTA empty state usesRealTimeDatabaseOffIllustrationfrom the design system in place of a local 192px SVG.@mui/icons-materialacross the sidebar, theme toggle, app bar, release notes and RTA controls.collapse-content,expand-content,bottom-panel-open) and the deadnodemap alias.perconamarker is now a theme-aware monochrome icon instead of a fixed orange–gold gradient, matching the other markers.How to test
In both light and dark themes, scan the left sidebar (MySQL/MongoDB/PostgreSQL/Valkey, OS, HAProxy/ProxySQL, Dashboards, Explore, Alerts, Advisors, Inventory, Backups, Configuration, Users and access, Account, Help, theme toggle) plus the app-bar logo and support icon. Then check the Help Center "PMM docs" card, the Updates → release-notes icons, and Real-Time Analysis (overview play/pause/refresh/export, the auto-refresh bolt, the details-pane collapse button, and the empty-state illustration).
No API changes.
Related work:
@percona/peak-ui@1.0.25.Testing screenshots: